Add opt in newline tolerance settings - #1826
Merged
Merged
Conversation
Restores, as opt in, the two tolerances removed in 7253acb. VerifierSettings.FixNewlinesOnRead normalizes \r\n and \r to \n when reading verified files, instead of rejecting a verified file that contains a carriage return. VerifierSettings.IgnoreTrailingNewline treats a verified file that ends in a single \n, where that newline accounts for the entire difference in length, as equal to the received content. Both are global and guarded by ThrowIfVerifyHasBeenRun, so a module initializer is the only place to set them. That makes either a repo level fix requiring no per developer setup, which is what #1824 asks for. Neither is a replacement for the .gitattributes and EditorConfig settings, and enabling them has side effects: line endings on disk diverge between accept workflows, the misconfiguration is no longer surfaced anywhere, diff output during a real mismatch is noisier, reported content no longer matches the bytes on disk, normalizing allocates, and IgnoreTrailingNewline can mask output that stops emitting a trailing newline. All documented in the new docs/newline-tolerance.md, linked from the exception message, the xml docs, and the doc index. Closes #1824
This was referenced Aug 1, 2026
Closed
This was referenced Aug 4, 2026
Merged
legrab
added a commit
to legrab/pocok
that referenced
this pull request
Aug 9, 2026
Updated [Verify.NUnit](https://github.com/VerifyTests/Verify) from 31.27.0 to 31.28.0. <details> <summary>Release notes</summary> _Sourced from [Verify.NUnit's releases](https://github.com/VerifyTests/Verify/releases)._ ## 31.28.0 - [x] [#1822](VerifyTests/Verify#1822) Option to not scrub N instance Guids - [x] [#1825](VerifyTests/Verify#1825) Add GuidFormats option to ScrubInlineGuids - [x] [#1826](VerifyTests/Verify#1826) Add opt in newline tolerance settings Commits viewable in [compare view](VerifyTests/Verify@31.27.0...31.28.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores, as opt in, the two tolerances removed in 7253acb.
VerifierSettings.FixNewlinesOnRead normalizes \r\n and \r to \n when reading verified files, instead of rejecting a verified file that contains a carriage return.
VerifierSettings.IgnoreTrailingNewline treats a verified file that ends in a single \n, where that newline accounts for the entire difference in length, as equal to the received content.
Both are global and guarded by ThrowIfVerifyHasBeenRun, so a module initializer is the only place to set them. That makes either a repo level fix requiring no per developer setup, which is what #1824 asks for.
Neither is a replacement for the .gitattributes and EditorConfig settings, and enabling them has side effects: line endings on disk diverge between accept workflows, the misconfiguration is no longer surfaced anywhere, diff output during a real mismatch is noisier, reported content no longer matches the bytes on disk, normalizing allocates, and IgnoreTrailingNewline can mask output that stops emitting a trailing newline. All documented in the new docs/newline-tolerance.md, linked from the exception message, the xml docs, and the doc index.
Closes #1824